Refactor tool blocks with declarative macros #58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add define_tool_block! and define_simple_tool_block! macros to eliminate repetitive boilerplate in tool block definitions. Each tool block now only needs to specify the custom header rendering logic. Refactored blocks: - ShellBlock, ReadFileBlock, WriteFileBlock, EditFileBlock - FetchUrlBlock, FetchHtmlBlock - ListAgentsBlock, GetAgentBlock - ListBackgroundTasksBlock, GetBackgroundTaskBlock The macros generate: - Struct definition with standard fields - new() and from_params() constructors - Full Block trait implementation - Common render() structure (status, approval, result, denied) This reduces ~870 lines of duplicated code to ~410 lines, with tool blocks now being ~15-30 lines instead of ~70-100 lines each. https://claude.ai/code/session_015xi85mutXbrHDKCU9WS511
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add define_tool_block! and define_simple_tool_block! macros to eliminate
repetitive boilerplate in tool block definitions. Each tool block now
only needs to specify the custom header rendering logic.
Refactored blocks:
The macros generate:
This reduces ~870 lines of duplicated code to ~410 lines, with tool
blocks now being ~15-30 lines instead of ~70-100 lines each.
https://claude.ai/code/session_015xi85mutXbrHDKCU9WS511